Fix build on PyPy #27359
Merged
Fix build on PyPy #27359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that `Py_FileSystemDefaultEncodeErrors` is not part of the limited API, and PyPy does not have it. Since pybind11 does not have a wrapper for `PyUnicode_EncodeFSDefault` (the main reason I had switched to a `encode` call earlier), we need to call it ourselves manually.
|
Is this a problem only for the meson builds? |
|
I don't think so; I forgot to mention it was caused by #26992 according to the CI logs. |
|
Ahh, okay, I was wondering if it needed to be backported (and possibly prompt another release), but the line that is changing is only on main, so don't think so. |
ksunden
approved these changes
Nov 21, 2023
jklymak
approved these changes
Nov 21, 2023
|
Should we be concerned that this has no test coverage? |
|
That is definitely wrong; we probably lost coverage for compiled code in the move to Meson. |
|
Looking at the coverage for the file directly, it's not really uncovered, but partially covered. This probably partially because we don't do coverage on non-Linux, but I'm investigating some outdated settings in the test config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
It appears that
Py_FileSystemDefaultEncodeErrorsis not part of the limited API, and PyPy does not have it. This broke wheel building CI only, as PyPy isn't otherwise built.Since pybind11 does not have a wrapper for
PyUnicode_EncodeFSDefault(the main reason I had switched to aencodecall earlier), we need to call it ourselves manually.PR checklist