ci: Improve coverage for compiled code#27363
Merged
Merged
Conversation
d048da7 to
d39310b
Compare
b74298a to
9810ac5
Compare
This condition was when we had Ubuntu 18.04 and added 20.04. When we dropped 18.04, and moved to 20.04+22.04, this condition should've been enabled everywhere.
Codecov shows the CI provider, but all jobs are tagged with the overall workflow ID. Passing a name allows differentiating between each build (i.e., Python version and system platform.)
9810ac5 to
dc759a1
Compare
Member
Author
|
It took several tries (coverage is only in Enterprise, so I can't test locally), but I finally have coverage on Windows with MSVC 2022. No matter what I tried though, I can't figure out MSVC 2019. I left it in there, if someone wants to try for it, but maybe since it's the older version, there's no need to worry about it too much. The overall codecov status doesn't seem to show any real change, but if you click on through, you can see that the compiled code did increase, but it went from partial to full coverage. |
ksunden
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This enables coverage for compiled code on macOS GitHub Actions, as well as all platforms on Azure Pipelines.
Unfortunately, I don't see any coverage for the Objective-C macosx backend, even though my testing showed that the flag was passed in there.
PR checklist