Remove test_spy from test_datetime.py #27392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksunden
requested changes
Nov 29, 2023
Comment on lines
497
to
505
| data = np.random.rand(10, 10) | ||
| data[data < 0.9] = 0 | ||
| fig, ax = plt.subplots() | ||
| sp = ax.spy(data) | ||
| ax.set_title('Spy Plot Test') | ||
| ax.set_xlabel('Column Index') | ||
| ax.set_ylabel('Row Index') | ||
| assert sp is not None, "Failed to create spy plot" | ||
| plt.close(fig) |
There was a problem hiding this comment.
Understood, I have redone it with datetime functionality.
|
I do not think that Therefore, I think the course of action for this method in particular is to simply remove the test template |
|
Ok, sounds good I can remove the test. |
64 tasks
ksunden
approved these changes
Nov 30, 2023
QuLogic
approved these changes
Dec 1, 2023
|
Thanks @rawwash! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. Note that I squash merged this PR, as there was no need for the separate commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Removing the test_spy for datetime, since does not make sense for unitful data. Spy is related to plotting at array indices, and provides no way of setting the x and y values to non-integer data.
Therefore, this PR aims to remove test_spy.
PR checklist