Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MEP22 first draft (DO NOT MERGE) #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fariza wants to merge 9 commits into from
Closed

MEP22 first draft (DO NOT MERGE) #2740

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3dd0a3e
Navigation, Toolbar and Tool in place
fariza Jan 16, 2014
128f1a7
stuff moved to new locations
fariza Jan 16, 2014
482e247
Removing prints
fariza Jan 16, 2014
72ce737
improving the example
fariza Jan 17, 2014
aae701b
adding locks for events, instead of modifying attributes
fariza Jan 21, 2014
e226cc0
moving class attribute to ToolBase
fariza Jan 21, 2014
deb834c
Reducing the number of public methods
fariza Jan 22, 2014
8835b9b
adding copy tool to example
fariza Jan 22, 2014
560868a
bug fix
fariza Jan 22, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
moving class attribute to ToolBase
  • Loading branch information
@fariza
fariza committed Jan 21, 2014
commit e226cc02801fa2908bb776c3a29110d6e6950307
6 changes: 3 additions & 3 deletions lib/matplotlib/backend_bases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2421,6 +2421,7 @@ class ToolBase(object):
image = None
toggle = False # Change the status (take control of the events)
persistent = False
cursor = None

def __init__(self, figure, event=None):
self.figure = figure
Expand Down Expand Up @@ -2608,7 +2609,6 @@ class SaveFigureBase(ToolBase):

class ToolToggleBase(ToolPersistentBase):
toggle = True
cursor = None

def mouse_move(self, event):
pass
Expand Down Expand Up @@ -3007,12 +3007,12 @@ def remove_tool(self, name):
def add_tool(self, callback_class):
tool = self._get_cls_to_instantiate(callback_class)
name = tool.name

if name is None:
warnings.warn('Tools need a name to be added, it is used as ID')
return
if name in self._tools:
warnings.warn('A tool with the same name already exist, not added')

return

self._tools[name] = tool
Expand Down Expand Up @@ -3349,7 +3349,7 @@ def set_message(self, s):
pass

def toggle(self, name, callback=False):
#callback = perform or not the callback while toggling
#carefull, callback means to perform or not the callback while toggling
raise NotImplementedError

def remove_toolitem(self, name):
Expand Down