Add test for fill_between in test_datetime.py#27423
Merged
oscargus merged 5 commits intomatplotlib:mainfrom Dec 5, 2023
Merged
Add test for fill_between in test_datetime.py#27423oscargus merged 5 commits intomatplotlib:mainfrom
oscargus merged 5 commits intomatplotlib:mainfrom
Conversation
Contributor
Author
|
this pull request resolves part of #26864 |
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
jklymak
approved these changes
Dec 3, 2023
Member
|
I believe that the second subplot can be removed since it is not related to dates (plain floats, which should be tested elsewhere). Otherwise makes sense. |
64 tasks
Member
|
Thanks! |
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
add code for test_fill_between in test_datetime.py as requested in #26864.
Output image:
PR checklist