-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Added Axes.stairs test in test_datetime.py #27424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Axes.stairs test in test_datetime.py #27424
Conversation
Tested error-free
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Thank you! I'd suggest using dates for more than just the x-axis (currently, the three subplots are testing the same thing). A common pattern is something like:
In this way, one can be a bit more certain that it works. |
I think that an explicit value should be passed for That also tests that the baseline behavior acts as we expect with unitful data. |
Hi! Thank you for your reply. I tried to use baseline but I found there is no where else using this baseline value in the test_datetime file. Is it necessary to use this value in this test? |
( |
Co-authored-by: Elliott Sales de Andrade <[email protected]>
Co-authored-by: Elliott Sales de Andrade <[email protected]>
Thank you for your suggestion! I have just committed your suggestions! |
Thanks @ifEricReturnTrue! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
PR summary
add code for Axes.stairs in test_datetime.py as requested in #26864.

PR checklist