Added test_fill_betweenx in test_datetime.py #27425
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thank you. I believe that one can probably skip the second subplot since that is only using floats (so not really related to the purpose of the test). |
Hi, I did that because both “axes.fill” and “axes.fill_between” did that as well for a comparison. I think it can be consistent if I keep this, but I can also remove it if you think it is unnecessary |
|
@xieruoyi Oscar raised the same objection to I agree that it should likely be removed, though I did in fact ignore that for |
|
|
PR summary
Added code for test_fill_betweenx in test_datetime.py as requested in #26864
Image for an output
PR checklist