Added default kwargs values to figure.suptitle() in rcParams and inheritance for function #27436
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thanks for this! Some quick notes: It seems like to naming is inconsistent in the files. For example: This will also need a "What's new"-note. |
|
Thanks for catching that. I settled for title_x and title_y as a good mix of both naming formats. |
|
there is still a mix of |
| @@ -331,8 +331,9 @@ def _suplabels(self, t, info, **kwargs): | |||
| @_docstring.copy(_suplabels) | |||
| def suptitle(self, t, **kwargs): | |||
| # docstring from _suplabels... | |||
| info = {'name': '_suptitle', 'x0': 0.5, 'y0': 0.98, | |||
| 'ha': 'center', 'va': 'top', 'rotation': 0, | |||
| info = {'name': '_suptitle', 'x0': 'figure.title_x', | |||
There was a problem hiding this comment.
I do not understand how x0 and y0 get turn from the rcParam names into actual values?
My guess is that this is related to the failures in the doc build
|
This needs a reabase and we think there is still a missing part of the implementation where we actually use the new rcparams. |
PR summary
This PR addresses issue #24090 which requests to added default kwargs parameters to use for function figure.suptitle() in rcParams. Basic default parameters have been added and adapted to use in inheritance. PR needs to be reviewed and can closes #24090.
PR checklist