Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add test_quiverkey to test_datetimes.py #27448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

Dkjam5511
Copy link
Contributor

@Dkjam5511 Dkjam5511 commented Dec 5, 2023

PR summary

Added datetime smoke test for Axes.quiverkey. Proves that a quiverkey label can have a datetime assigned to it

This is one of the tests tasked by #26864

image

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@ksunden
Copy link
Member

ksunden commented Dec 5, 2023

I do not think this is actually exercising the units machinery that is the goal of these tests (and don't really think it has any real way to test it)

While it is using datetimes for the x values, that is part of the quiver test (#27407) rather than the quiverkey test, and the place where a datetime is passed here is just treated as str, not under its unitful numeric representation.

Thus I think the course of action is to remove this test.

@Dkjam5511
Copy link
Contributor Author

Yeah, looking at it again I agree. This isn't that applicable to datetime. I'll close this PR and make a new one to remove test_quiverkey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants