Added smoke test for Axes.imshow to test_datetime.py#27476
Merged
QuLogic merged 2 commits intomatplotlib:mainfrom Dec 12, 2023
Merged
Added smoke test for Axes.imshow to test_datetime.py#27476QuLogic merged 2 commits intomatplotlib:mainfrom
QuLogic merged 2 commits intomatplotlib:mainfrom
Conversation
QuLogic
reviewed
Dec 8, 2023
Member
QuLogic
left a comment
There was a problem hiding this comment.
I'm not too sure we need all 4 scales, as that is testing the concise date formatter, not anything specific to imshow.
… days, the axes labels now look like dates instead of just the year.
Contributor
Author
|
I futzed with it a bit more and found that if I removed "concise" and used a tighter date range than the axis labels looked like dates (see below). Originally at first the labels were only the year number which I thought might be confusing as it didn't look like a date. Let me know what you think!
|
jklymak
approved these changes
Dec 11, 2023
64 tasks
QuLogic
approved these changes
Dec 12, 2023
Member
|
Thanks @ConstableCatnip! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR adds a smoke test for
Axes.imshowin lib/matplotlib/tests/test_datetime.py and addresses taskAxes.imshowin issue #26864. Due to the behavior ofAxes.imshowwith thempl.rcParams["date.converter"] = "concise", I included year, month, day, and time axis scale plots.Below is the image of the generated plot:
PR checklist