MNT: Clean up some style exceptions #27546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of using a full file ignore. This allows catching a few more unused imports.
There's only one or two lines that need this exception, so the entire file doesn't need to be exempted.
There are really not very many of these to justify exempting the entire file, and they are easily fixed.
timhoffm
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
In these cases, a very small percentage of a file really needs an exception, so we can either add a
noqacomment, or fix the style issue directly.In files like
pyplot.py, the file-level exception was obscuring that imports likerewere unused, or thattyping.castwas imported twice.PR checklist