Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cleanup viewlims example. #27594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2024
Merged

Cleanup viewlims example. #27594

merged 1 commit into from
Jan 4, 2024

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 3, 2024

  • No need to subclass Rectangle; a plain callback is fine.
  • ax.get_xlim/ylim seems more idiomatic than accessing viewLims.
  • Skip duplicated code in initialization.

Closes #25979. Supersedes #26166.

PR summary

PR checklist

@anntzer anntzer added the Documentation: examples files in galleries/examples label Jan 3, 2024
@anntzer
Cleanup viewlims example.
f8cd003 
- No need to subclass Rectangle; a plain callback is fine.
- ax.get_xlim/ylim seems more idiomatic than accessing viewLims.
- Skip duplicated code in initialization.
@oscargus oscargus added this to the v3.8-doc milestone Jan 4, 2024
@oscargus oscargus merged commit c287b9f into matplotlib:main Jan 4, 2024
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 4, 2024
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 4, 2024
@oscargus @meeseeksmachine
Backport PR matplotlib#27594: Cleanup viewlims example.
2445d11
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 4, 2024
@oscargus @meeseeksmachine
Backport PR matplotlib#27594: Cleanup viewlims example.
14aa4e0
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 4, 2024
Merged
@oscargus oscargus mentioned this pull request Jan 4, 2024
Closed
5 tasks
@anntzer anntzer deleted the vl branch January 4, 2024 09:28
oscargus added a commit that referenced this pull request Jan 4, 2024
@oscargus
Merge pull request #27598 from meeseeksmachine/auto-backport-of-pr-27…
2a78015 
…594-on-v3.8.x

Backport PR #27594 on branch v3.8.x (Cleanup viewlims example.)
oscargus added a commit that referenced this pull request Jan 4, 2024
@oscargus
Merge pull request #27599 from meeseeksmachine/auto-backport-of-pr-27…
0093675 
…594-on-v3.8.2-doc

Backport PR #27594 on branch v3.8.2-doc (Cleanup viewlims example.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
Documentation: examples files in galleries/examples
Projects
None yet
Milestone
v3.8-doc
Development

Successfully merging this pull request may close these issues.

[Doc]: Cleanup viewlims example
2 participants
@anntzer @oscargus