Let FormatStrFormatter respect axes.unicode_minus. #27602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
story645
approved these changes
Jan 5, 2024
This is better than the workaround of wrapping the expression in mathtext (as suggested for the old-style FormatStrFormatter) because it also works for the hover tooltip in the toolbar (which cannot display mathtext). Note that it is not as easy to do so for FormatStrFormatter (%-formatting) as that would require manually parsing the format string; I would not bother as that formatter seems to be mostly present for backcompat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is better than the workaround of wrapping the expression in
mathtext (as suggested for the old-style FormatStrFormatter) because it
also works for the hover tooltip in the toolbar (which cannot display
mathtext).
Note that it is not as easy to do so for FormatStrFormatter
(%-formatting) as that would require manually parsing the format string;
I would not bother as that formatter seems to be mostly present for
backcompat.
Goes on top of #27601.
PR summary
PR checklist