Add method to update position of arrow patch #27692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While the arrow patch has fundamental flaws, it's not going to go away soon. So this addition is reasonable. |
story645
reviewed
Jan 24, 2024
story645
reviewed
Jan 24, 2024
story645
reviewed
Jan 28, 2024
| ax.add_patch(a) | ||
|
|
||
| # code for modifying the arrow | ||
| a.set_data(x=.5, dx=3, dy=8, width=1.2) |
There was a problem hiding this comment.
Suggested change
| a.set_data(x=.5, dx=3, dy=8, width=1.2) | |
| def update(i): | |
| a.set_data(x=.5, dx=3, dy=8, width=1.2) |
how would you feel about making this a tiny animation to advertise the purpose of the method?
There was a problem hiding this comment.
That sounds good. I'll have a go at making an animation
story645
reviewed
Jan 29, 2024
Comment on lines
+1315
to
+1319
| x, y : float or None, default: None | ||
| The x and y coordinates of the arrow base. | ||
|
|
||
| dx, dy : float or None, default: None | ||
| The length of the arrow along x and y direction. |
There was a problem hiding this comment.
Is tedious but I think these need to be documented individually since they come in individually and not as tuples.
There was a problem hiding this comment.
This is correct as is. numpydoc explicitly allows this:
When two or more input parameters have exactly the same type, shape and description, they can be combined:
timhoffm
approved these changes
Jan 29, 2024
story645
approved these changes
Jan 29, 2024
dstansby
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #14217. Adds
set_datamethod fromFancyArrowthat allows the arrow to be repositioned without re-drawing.Arrow's
x,y,dx,dyandwidthparameters are now stored in private variables so that they can be reused for recreating the transform.e.g.
See the discussion here #14217 (comment). I don't know what the consensus is on the Arrow class but If this fix is still needed, I'll add a test and a what's new entry.
PR checklist