MNT/ENH: make hist and friends more forgiving of array-like #27714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, this works fine, but doesn't speed up jax/torch. The basic problem now is that a JAX Array gets sent to I'll close this as its basically a Gordian knot, and I agree that if we want to allow jax/tensor then a cutout as in #25887 is probably the best we can do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate to #25887.
Not sure it is correct yet, but the idea is
Xhasiloc. Basically pandas.ndarrays, it does them ifXhasndimandT, both of which are required.ndim. I was a little unclear if it supportsT, but it has a transpose method, so I expect it does.Still needs testing that these array-like libraries work. But if a numpy-like array doesn't support
X.TandX.ndim....PR summary
PR checklist