-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
macOS: Check for display availability when looking for backends #27761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a3255ec
to
d6179de
Compare
d6179de
to
e8943a0
Compare
I can confirm that this:
|
Running the tests on this branch locally without a user logged in to the desktop (so launched via ssh) I get:
This suggests that what is going on the CI is slightly different than not having a display? |
On Actions, the display does appear to exist, according to the results from #27723:
For your failures, I think that's because the macOS tests don't have a skip, so I hadn't added one (only modified existing ones.) |
e8943a0
to
bcc570b
Compare
I tried re-running the failed mac3.11 jobs. |
Looking at https://stackoverflow.com/questions/71954472/tkinter-crashes-on-ipython-but-not-in-python-on-a-m1-mac I think this might be because |
Ah, here's a full explanation:
but substitute the new code written here for AFAICT from Googling though, we need the Can you check if it works without the |
PR summary
This checks
NSScreen::mainScreen
similar to checking$DISPLAY
/$WAYLAND_DISPLAY
on Linux.Fixes #26292
PR checklist