Fix sphinx-gallery CSS #27798
Merged
Fix sphinx-gallery CSS #27798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The div.figure was removed in sphinx-gallery/sphinx-gallery#906 The workaround is also not needed anymore because that PR fixes the centering.
... so that lazy loading does not change heights. Without a fixed height lazy loading of images interferes with anchor links: Clicking a link goes to a certain position, but then the loaded images add content and move the anchor to a different position.
|
The fixed navigation behavior can be tested in the build docs: |
dstansby
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collects two commits:
Remove unused
.sphx-glr-thumbcontainer .figure. The.figurediv was removed insphinx-gallery/sphinx-gallery#906
The workaround is also not needed anymore because that PR fixes the
centering.
Set a fixed height for sphinx gallery images
... so that lazy loading does not change heights. Without a fixed
height lazy loading of images interferes with anchor links: Clicking a
link goes to a certain position, but then the loaded images add content
and move the anchor to a different position.
The position change problem that this addresses can be reproduces as follows: