Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove self._renderer from AnnotationBbox and ConnectionPatch #27806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Feb 20, 2024

PR summary

As far as I can tell, these are unused, and cause problems for pickling

Closes #27805

See #27805 (comment) for more details.

PR checklist

As far as I can tell, these are unused, and cause problems for pickling

Closes matplotlib#27805
@ksunden ksunden added the topic: pickle Issues to do with pickling label Feb 20, 2024
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, that they seem unused.

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can't find any use for it either.

@QuLogic QuLogic merged commit 631e171 into matplotlib:main Feb 21, 2024
@QuLogic QuLogic added this to the v3.9.0 milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: pickle Issues to do with pickling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Saving a figure with indicate_inset_zoom to pdf and then pickling it causes TypeError
3 participants