Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MNT: Remove remaining 3.7 deprecations #27968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 23, 2024

PR summary

Not sure why I missed listing these in #26865.

PR checklist

rcomer
rcomer previously approved these changes Mar 23, 2024
Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR number in the changenote filename is 2 out but otherwise this looks good to me.

@rcomer rcomer dismissed their stale review March 23, 2024 08:23

failing test

Not sure why I missed listing these in matplotlib#26865.
@QuLogic QuLogic force-pushed the remove-3.7-deprecations branch from 6aebd88 to a78a3d8 Compare March 23, 2024 08:30
@rcomer
Copy link
Member

rcomer commented Mar 23, 2024

Looks like Appveyor is running out of time? I re-started it but same result.

Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave it to second reviewer to decide if the Appveyor failure matters, but I suspect it does not.

@dstansby dstansby merged commit 6799367 into matplotlib:main Mar 24, 2024
@QuLogic QuLogic deleted the remove-3.7-deprecations branch March 25, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants