Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Fix inconsistent spacing in some docstrings in _axes.py #28037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

saranti
Copy link
Contributor

@saranti saranti commented Apr 6, 2024

PR summary

Some of the docstrings in _axes.py had the wrong amount of spacing (either 2 or 3 spaces) instead of 4. This PR makes them conform with the rest.

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I wonder if there's a way to enforce/automate this 🤔

@timhoffm
Copy link
Member

timhoffm commented Apr 7, 2024

Looks good - I wonder if there's a way to enforce/automate this 🤔

There's pydocstyle

  • D214 Section is over-indented
  • D215 Section underline is over-indented

which AFAICS is active in flake8 through flake8-docstrings. But probably, they don't apply because the parameter lists are technically definition lists and they may not be covered by these rules.

Semi-OT: I've noticed that pydocstyle (and with it flake8-docstrings) is deprecated. The recommended replacement is ruff. Mid-term we need to move there.

@timhoffm timhoffm added this to the v3.10.0 milestone Apr 7, 2024
@timhoffm timhoffm merged commit 68daa96 into matplotlib:main Apr 7, 2024
@saranti saranti deleted the axesdocs branch April 8, 2024 03:17
@ksunden ksunden changed the title DOC: Fix inconsistant spacing in some docstrings in _axes.py DOC: Fix inconsistent spacing in some docstrings in _axes.py Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants