-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Enables setting hatch linewidth in Patches and Collections, also fixes setting hatch linewidth by rcParams #28048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't know why docs and CI are failing, could somebody please check this out? |
Hi @Impaler343, I'm not certain but I think the docs failure may be related to something that has been fixed on
Appveyor is showing the same failure on all PRs right now, so I wouldn't worry about that one. |
Do I also need to squash? |
There is enough exploration/experimentation in here it is probably worth squashing to a handful of commits. |
I think this is like 80% of the way there and looking pretty good! |
Can we get a feature for |
I do not think this is required? The reason |
I suggested this as it is a quick plugin to make tests run faster by focussing on the important part of the plot, by removing axes, labels and ticks, and this most probably should make a significant difference while running a large amount of tests |
Problems were introduced by matplotlib#28048, specifically relating to set_sizes. I simply ran with the flag to regenerate, so more changes were made, which I do not fully understand why they were not problematic earlier.
Problems were introduced by matplotlib#28048, specifically relating to set_sizes. I simply ran with the flag to regenerate, so more changes were made, which I do not fully understand why they were not problematic earlier.
Problems were introduced by matplotlib#28048, specifically relating to set_sizes. I simply ran with the flag to regenerate, so more changes were made, which I do not fully understand why they were not problematic earlier.
PR summary
Fixes #21108 using the patch provided by @anntzer which I modified to pass tests. Need to write tests for:
PR checklist