[TST] Bump some tolerances for Macos ARM #28188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
May 8, 2024
timhoffm
approved these changes
May 9, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 9, 2024
timhoffm
added a commit
that referenced
this pull request
May 9, 2024
…188-on-v3.9.x Backport PR #28188 on branch v3.9.x ([TST] Bump some tolerances for Macos ARM)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Closes #28168
Closes #28145
Closes #28034
Some tolerances were just a bit tight and for some reason fell on the other side here (Including a couple that rounded to the same number as the tolerance).
One test I swapped from "if you are one of these archetectures add a tolerance" to "if you are x64, don't add a tolerance".
Checked the images, most of these were not human-visible. The line collection test had the largest change, but already had a large enough tolerance on other platforms, so just extended that.
PR checklist