Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Backport PR #28205 on branch v3.9.x (TST: Fix tests with older versions of ipython) #28206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #28205: TST: Fix tests with older versions of ipython

Make the changes suggested by @ianthomas23, and also mark the ipython
tests as using their backend. While the backend is already checked for
availability at the top of the respective files, that only checks
whether it can be imported, not whether it can be set as the Matplotlib
backend. Adding the marker causes our pytest configuration to actually
check and skip the test if unavailable (e.g., on Linux without
`(WAYLAND_)DISPLAY` set fails to set an interactive backend).
Copy link
Member

@ianthomas23 ianthomas23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming CI passes.

@ksunden ksunden merged commit 8604f67 into matplotlib:v3.9.x May 13, 2024
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants