Handle GetForegroundWindow() returning NULL. #28269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetForegroundWindow() is documented as sometimes returning NULL, which is not a valid argument to PyCapsule_New. Use None to cover that case, instead.
tacaswell
approved these changes
May 21, 2024
QuLogic
approved these changes
May 21, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 21, 2024
timhoffm
added a commit
that referenced
this pull request
May 21, 2024
…269-on-v3.9.x Backport PR #28269 on branch v3.9.x (Handle GetForegroundWindow() returning NULL.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetForegroundWindow() is documented as sometimes returning NULL (https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getforegroundwindow), which is not a valid argument to PyCapsule_New. Use None to cover that case, instead.
Closes #28267 (in all likelihood...).
PR summary
PR checklist