Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix draggable legend disappearing when picking while use_blit=True #28271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Fix draggable legend disappearing when picking while use_blit=True #28271

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
255875d
Fix draggable legend disappearing when picking while use_blit=True
vittoboa May 21, 2024
9c03278
Add draw/blit to on_release of draggable lenged
vittoboa May 22, 2024
ee36329
Restore background before draw/blit in on_release of draggable legend
vittoboa May 22, 2024
f186514
Format drawing of draggable legend in on_release into a single line
vittoboa Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions lib/matplotlib/offsetbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,25 +1486,30 @@ def on_motion(self, evt):
self.canvas.draw()

def on_pick(self, evt):
if self._check_still_parented() and evt.artist == self.ref_artist:
self.mouse_x = evt.mouseevent.x
self.mouse_y = evt.mouseevent.y
self.got_artist = True
if self._use_blit:
if self._check_still_parented():
if evt.artist == self.ref_artist:
self.mouse_x = evt.mouseevent.x
self.mouse_y = evt.mouseevent.y
self.save_offset()
self.got_artist = True
if self.got_artist and self._use_blit:
self.ref_artist.set_animated(True)
self.canvas.draw()
self.background = \
self.canvas.copy_from_bbox(self.ref_artist.figure.bbox)
self.ref_artist.draw(
self.ref_artist.figure._get_renderer())
self.canvas.blit()
self.save_offset()

def on_release(self, event):
if self._check_still_parented() and self.got_artist:
self.finalize_offset()
self.got_artist = False
if self._use_blit:
self.canvas.restore_region(self.background)
self.ref_artist.draw(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to restore the background as well here or you will double-draw the legend (set it to have a colored and fraction alpha background to see the effect).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah that's right, added the restoration!

self.ref_artist.figure._get_renderer())
self.canvas.blit()
self.ref_artist.set_animated(False)

def _check_still_parented(self):
Expand Down