Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revive sanitizing default filenames extracted from UI window titles #28275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Revive sanitizing default filenames extracted from UI window titles #28275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d2289d
Sanitize default filename.
anntzer Aug 18, 2017
4356bfe
MNT: use the same replace chars on all OS
tacaswell Aug 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions lib/matplotlib/backend_bases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2241,15 +2241,22 @@ def get_default_filetype(cls):

def get_default_filename(self):
"""
Return a string, which includes extension, suitable for use as
a default filename.
"""
basename = (self.manager.get_window_title() if self.manager is not None
else '')
basename = (basename or 'image').replace(' ', '_')
filetype = self.get_default_filetype()
filename = basename + '.' + filetype
return filename
Return a suitable default filename, including the extension.
"""
default_basename = (
self.manager.get_window_title()
if self.manager is not None
else ''
)
default_basename = default_basename or 'image'
# Characters to be avoided in a NT path:
# https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx#naming_conventions
# plus ' '
removed_chars = r'<>:"/\|?*\0 '
default_basename = default_basename.translate(
{ord(c): "_" for c in removed_chars})
default_filetype = self.get_default_filetype()
return f'{default_basename}.{default_filetype}'

@_api.deprecated("3.8")
def switch_backends(self, FigureCanvasClass):
Expand Down
Loading