Document that axes unsharing is impossible. #28359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the quick PR. Just curious, should this note also apply to Axes3D.sharez ? From a quick look, perhaps not. The documentation says sharez can only be used once, so I guess maybe there is a different / simpler sharing mechanism for z? This doesn't effect me, just though I would mention it. |
|
I expect that this will apply to |
|
Sure, documented the limitation for sharez too. |
|
Axes3D shareview as well. |
The feature may perhaps be desirable, but let's document the current state of things.
|
Sure, done. |
scottshambaugh
approved these changes
Jun 10, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 10, 2024
|
That's all the sharing that's done, merging with the single review for a low-impact docs change. |
5 tasks
timhoffm
added a commit
that referenced
this pull request
Jun 11, 2024
…359-on-v3.9.x Backport PR #28359 on branch v3.9.x (Document that axes unsharing is impossible.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature may perhaps be desirable, but let's document the current state of things.
See #28345 (comment).
PR summary
PR checklist