Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX: stale root Figure when adding/updating subfigures #28397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2024
Merged

FIX: stale root Figure when adding/updating subfigures #28397

merged 1 commit into from
Jun 26, 2024

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Jun 14, 2024

PR summary

Fixes #28384

PR checklist

@rcomer rcomer added the PR: bugfix Pull requests that fix identified bugs label Jun 14, 2024
QuLogic
QuLogic reviewed Jun 14, 2024
View reviewed changes
@rcomer rcomer added this to the v3.9.1 milestone Jun 26, 2024
@tacaswell tacaswell merged commit d347c32 into matplotlib:main Jun 26, 2024
44 of 45 checks passed
@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Jun 26, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.9.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 d347c3227f8de8a99aa327390fee619310452a96
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #28397: FIX: stale root Figure when adding/updating subfigures'
  1. Push to a named branch:
git push YOURFORK v3.9.x:auto-backport-of-pr-28397-on-v3.9.x
  1. Create a PR against branch v3.9.x, I would have named this PR:

"Backport PR #28397 on branch v3.9.x (FIX: stale root Figure when adding/updating subfigures)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@rcomer rcomer deleted the subfigure-stale branch June 27, 2024 07:28
rcomer pushed a commit to rcomer/matplotlib that referenced this pull request Jun 27, 2024
@tacaswell @rcomer
Merge pull request matplotlib#28397 from rcomer/subfigure-stale
bbb0d01 
Backport PR matplotlib#28397: FIX: stale root Figure when adding/updating subfigures
(cherry picked from commit d347c32)
@rcomer rcomer mentioned this pull request Jun 27, 2024
Merged
5 tasks
QuLogic added a commit that referenced this pull request Jun 27, 2024
@QuLogic
Merge pull request #28479 from rcomer/v3.9.x
24e3013 
Backport PR #28397 (FIX: stale root Figure when adding/updating subfigures)
@rcomer rcomer mentioned this pull request Jul 11, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
PR: bugfix Pull requests that fix identified bugs topic: figures and subfigures
Projects
None yet
Milestone
v3.9.1
Development

Successfully merging this pull request may close these issues.

[Bug]: subfigure artists not drawn interactively
3 participants
@rcomer @tacaswell @QuLogic