Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add GIL Release to flush_events in macosx backend #28398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Jun 14, 2024

Closes #28387

PR summary

This ensures that we do not get a deadlock when we try to close tabs.

PR checklist

Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @ksunden! I have verified that this works as expected locally and tried various orders of closing operations with/without tabs etc. It also does not bring back the previous segfaults.

@tacaswell tacaswell added this to the v3.9.1 milestone Jun 14, 2024
@QuLogic QuLogic merged commit 82551e6 into matplotlib:main Jun 26, 2024
39 of 42 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 26, 2024
QuLogic added a commit that referenced this pull request Jun 26, 2024
…398-on-v3.9.x

Backport PR #28398 on branch v3.9.x (Add GIL Release to flush_events in macosx backend)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can not close figure when using multiple figures on MacOS X
4 participants