Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Circle yaml line length #28425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Jun 19, 2024

PR summary

#28413 introduced a pre-commit failure for the line length, that we missed amongst all the other CI failures.

PR checklist

@rcomer rcomer added the Documentation: build building the docs label Jun 19, 2024
@rcomer rcomer added this to the v3.9.1 milestone Jun 19, 2024
@ksunden ksunden merged commit 603001f into matplotlib:main Jun 19, 2024
35 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 19, 2024
@ksunden
Copy link
Member

ksunden commented Jun 19, 2024

Hmmm... this worked here in the PR, but failed with "unable to find version \n" once merged... that is

I note that the newline is included in the error message, which is likely important.

I believe that since it is triggered by [status] the version on main is always the one that is run, which makes changing it challenging since it can't be tested without merging...

@ksunden ksunden mentioned this pull request Jun 19, 2024
5 tasks
@rcomer rcomer deleted the circle-ci-line-length branch June 19, 2024 20:22
ksunden added a commit that referenced this pull request Jun 21, 2024
…425-on-v3.9.x

Backport PR #28425 on branch v3.9.x (Fix Circle yaml line length)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: build building the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants