-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Bump minimum Python to 3.10 #28503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum Python to 3.10 #28503
Conversation
b18c681
to
f766d3b
Compare
It looks like we have problems building on PyPy3.10 because NumPy doesn't have wheels yet numpy/numpy#26141 Also, not sure if the original test condition on the ipynb test is wrong, since it's failing here. |
I think we just skip pypy310 on at least windows, maybe all platforms. |
I added a However, |
I think your ipython pin should be 7.29.0 as that was released in October 2021, the same month as Python 3.10. That is consistent with ipykernel 5.5.6. The test passes locally for me using these. |
I forgot about Cygwin here; I believe they only have 3.9, and the plan is to jump to 3.12 directly: numpy/numpy#26222 (comment) We'll have to disable it in the meantime. |
Could we also add a minimum pin for python in environment.yml? For some reason mamba gives me 3.9 by default, but it also resolves fine if I pin it higher. |
if: >- | ||
github.event_name == 'workflow_dispatch' || | ||
github.event_name == 'schedule' || | ||
(false && github.event_name == 'schedule') || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to keep the false
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
answer: yes, cygwin is skipping 3.10 and 3.11, but is not ready for 3.12, so will be re-enabled later
PR summary
It's time for this by SPEC0, and our nightly build has started failing since Pandas has already dropped 3.9 support.
Fixes #28489
Draft because I need to see if I got the minimum Qt dependencies right.
PR checklist