Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump minimum Python to 3.10 #28503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Bump minimum Python to 3.10 #28503

merged 1 commit into from
Jul 13, 2024

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jul 3, 2024

PR summary

It's time for this by SPEC0, and our nightly build has started failing since Pandas has already dropped 3.9 support.

Fixes #28489

Draft because I need to see if I got the minimum Qt dependencies right.

PR checklist

@github-actions github-actions bot added the CI: Run cibuildwheel Run wheel building tests on a PR label Jul 3, 2024
@QuLogic QuLogic force-pushed the py310 branch 2 times, most recently from b18c681 to f766d3b Compare July 3, 2024 05:46
@github-actions github-actions bot added the Documentation: devdocs files in doc/devel label Jul 3, 2024
@QuLogic
Copy link
Member Author

QuLogic commented Jul 3, 2024

It looks like we have problems building on PyPy3.10 because NumPy doesn't have wheels yet numpy/numpy#26141

Also, not sure if the original test condition on the ipynb test is wrong, since it's failing here.

@tacaswell
Copy link
Member

I think we just skip pypy310 on at least windows, maybe all platforms.

@QuLogic
Copy link
Member Author

QuLogic commented Jul 5, 2024

I added a ipykernel==5.5.6 requirement to the older ipython job, as pip was walking back the versions to find a compatible one, so probably best to help it along with a pin.

However, test_ipynb is failing, and it seems like we are getting module://ipykernel.pylab.backend_inline instead of our expected module://ipykernel.pylab.backend_inline, and I'm not sure why it's only happening now with Python 3.10 instead of the older 3.9, but I can reproduce locally. cc @ianthomas23

@ianthomas23
Copy link
Member

I think your ipython pin should be 7.29.0 as that was released in October 2021, the same month as Python 3.10. That is consistent with ipykernel 5.5.6. The test passes locally for me using these.

@QuLogic
Copy link
Member Author

QuLogic commented Jul 5, 2024

I forgot about Cygwin here; I believe they only have 3.9, and the plan is to jump to 3.12 directly: numpy/numpy#26222 (comment)

We'll have to disable it in the meantime.

@github-actions github-actions bot added the CI: Run cygwin Run cygwin tests on a PR label Jul 5, 2024
@QuLogic QuLogic marked this pull request as ready for review July 5, 2024 22:08
@rcomer
Copy link
Member

rcomer commented Jul 13, 2024

Could we also add a minimum pin for python in environment.yml? For some reason mamba gives me 3.9 by default, but it also resolves fine if I pin it higher.

@QuLogic QuLogic added this to the v3.10.0 milestone Jul 13, 2024
if: >-
github.event_name == 'workflow_dispatch' ||
github.event_name == 'schedule' ||
(false && github.event_name == 'schedule') ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to keep the false here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answer: yes, cygwin is skipping 3.10 and 3.11, but is not ready for 3.12, so will be re-enabled later

@ksunden ksunden merged commit dc64946 into matplotlib:main Jul 13, 2024
40 of 42 checks passed
@QuLogic QuLogic deleted the py310 branch July 13, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Run cibuildwheel Run wheel building tests on a PR CI: Run cygwin Run cygwin tests on a PR Documentation: devdocs files in doc/devel Documentation: user guide files in galleries/users_explain or doc/users topic: sankey topic: styles topic: ticks axis labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TST] Upcoming dependency test failures
5 participants