Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding tags to many examples #28569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 12, 2024
Merged

Conversation

dihm
Copy link
Contributor

@dihm dihm commented Jul 13, 2024

PR summary

Adds tags to examples from the color, pie & polar, subplots & axes & figures, and lines & bars & markers example folder directories. I've made best guess attempts at tagging; happy to make edits as seen fit by the maintainers.

I've added a number of tags not in the tag glossary in anticipation of #28565 being resolved.

PR checklist

@github-actions github-actions bot added the Documentation: examples files in galleries/examples label Jul 13, 2024
@dihm dihm force-pushed the dihm_example_tagging branch from 5dc1f3c to 78e16ff Compare July 14, 2024 01:05
@ksunden ksunden added the Documentation: tags tagging examples + proposing new tags label Jul 14, 2024
@QuLogic QuLogic added the mentored: sprint Issues intended and suitable for sprints label Jul 18, 2024
@story645 story645 requested a review from QuLogic August 2, 2024 19:18
@jklymak
Copy link
Member

jklymak commented Sep 2, 2024

Can this get rebased and merged? Its a bit weird to have "tags" advertised heavily on the Examples page, but then have nothing tagged....

@dihm
Copy link
Contributor Author

dihm commented Sep 3, 2024

Ugh. Apologies. I hadn't tracked the bot update on needing a rebase.

@jklymak
Copy link
Member

jklymak commented Sep 3, 2024

@dihm Not your fault! Thanks for the help...

@dihm
Copy link
Contributor Author

dihm commented Sep 3, 2024

Think I did the rebase correctly, but best be sure. One file was deleted on main (filled_step.py), want to make sure I didn't accidentally re-add it.

@dihm
Copy link
Contributor Author

dihm commented Sep 3, 2024

And the docs build is broken again. Error is coming from an example this PR doesn't touch.

Extension error:
Here is a summary of the problems encountered when running the examples:

Unexpected failing examples (1):

    ../galleries/examples/units/radian_demo.py failed leaving traceback:

    Traceback (most recent call last):
      File "/home/circleci/project/galleries/examples/units/radian_demo.py", line 26, in <module>
        axs[0].plot(x, cos(x), xunits=radians)
                       ^^^^^^
      File "/home/circleci/project/galleries/examples/units/basic_units.py", line 382, in cos
        return [math.cos(val.convert_to(radians).get_value()) for val in x]
                         ^^^^^^^^^^^^^^
    AttributeError: 'numpy.float64' object has no attribute 'convert_to'

A quick look comparing this PR to #28771, which built correctly 3 hours ago, seems like numpy switching from v2.0.2 to v2.1.1 may be the culprit.

@jklymak
Copy link
Member

jklymak commented Sep 3, 2024

Recycling to catch the updated numpy config....

@jklymak jklymak closed this Sep 3, 2024
@jklymak jklymak reopened this Sep 3, 2024
@jklymak
Copy link
Member

jklymak commented Sep 3, 2024

Sorry recycling doesn't re-run the tests. @dihm happy to push a rebase to your branch, or if you can do it, that would be great.

@dihm dihm force-pushed the dihm_example_tagging branch from fc00fc3 to e88c235 Compare September 4, 2024 00:19
@dihm
Copy link
Contributor Author

dihm commented Sep 4, 2024

@jklymak Rebase pushed and docs have built!

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have largely worked. I didn't double check everything, but that could be a cleanup.

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small typo

Co-authored-by: Elliott Sales de Andrade <[email protected]>
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good; do you want to rebase and squash the fixes into the original commits, squash everything on merge, or leave as is?

@dihm
Copy link
Contributor Author

dihm commented Sep 9, 2024

This seems good; do you want to rebase and squash the fixes into the original commits, squash everything on merge, or leave as is?

I suppose this was a question for me? I don't have a preference. Happy to do whatever works best for the y'all.

@QuLogic
Copy link
Member

QuLogic commented Sep 12, 2024

OK, we will squash merge.

@QuLogic QuLogic merged commit 3b3576d into matplotlib:main Sep 12, 2024
22 checks passed
@QuLogic QuLogic added this to the v3.10.0 milestone Sep 12, 2024
@dihm dihm deleted the dihm_example_tagging branch September 12, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: examples files in galleries/examples Documentation: tags tagging examples + proposing new tags mentored: sprint Issues intended and suitable for sprints
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

4 participants