-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Adding tags to many examples #28569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tags to many examples #28569
Conversation
5dc1f3c
to
78e16ff
Compare
Can this get rebased and merged? Its a bit weird to have "tags" advertised heavily on the Examples page, but then have nothing tagged.... |
Ugh. Apologies. I hadn't tracked the bot update on needing a rebase. |
@dihm Not your fault! Thanks for the help... |
f719a9b
to
fc00fc3
Compare
Think I did the rebase correctly, but best be sure. One file was deleted on main ( |
And the docs build is broken again. Error is coming from an example this PR doesn't touch. Extension error:
Here is a summary of the problems encountered when running the examples:
Unexpected failing examples (1):
../galleries/examples/units/radian_demo.py failed leaving traceback:
Traceback (most recent call last):
File "/home/circleci/project/galleries/examples/units/radian_demo.py", line 26, in <module>
axs[0].plot(x, cos(x), xunits=radians)
^^^^^^
File "/home/circleci/project/galleries/examples/units/basic_units.py", line 382, in cos
return [math.cos(val.convert_to(radians).get_value()) for val in x]
^^^^^^^^^^^^^^
AttributeError: 'numpy.float64' object has no attribute 'convert_to' A quick look comparing this PR to #28771, which built correctly 3 hours ago, seems like numpy switching from v2.0.2 to v2.1.1 may be the culprit. |
Recycling to catch the updated numpy config.... |
Sorry recycling doesn't re-run the tests. @dihm happy to push a rebase to your branch, or if you can do it, that would be great. |
fc00fc3
to
e88c235
Compare
@jklymak Rebase pushed and docs have built! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to have largely worked. I didn't double check everything, but that could be a cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small typo
Co-authored-by: Elliott Sales de Andrade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good; do you want to rebase and squash the fixes into the original commits, squash everything on merge, or leave as is?
I suppose this was a question for me? I don't have a preference. Happy to do whatever works best for the y'all. |
OK, we will squash merge. |
PR summary
Adds tags to examples from the color, pie & polar, subplots & axes & figures, and lines & bars & markers example folder directories. I've made best guess attempts at tagging; happy to make edits as seen fit by the maintainers.
I've added a number of tags not in the tag glossary in anticipation of #28565 being resolved.
PR checklist