Copy all internals from initial Tick to lazy ones #28577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Jul 17, 2024
|
@QuLogic decide yourself if / how to test this. May self-merge, then. |
This is used only for XTick._apply_tickdir, and YTick._apply_tickdir uses a different dictionary.
|
I wasn't able to find a good way to test the layout portion directly, so I went with the more straightforward, though perhaps tautological, version of just asserting the copied attributes. I also made one more change of adding a |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 7, 2024
oscargus
added a commit
that referenced
this pull request
Aug 8, 2024
…577-on-v3.9.x Backport PR #28577 on branch v3.9.x (Copy all internals from initial Tick to lazy ones)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Ticks will follow the
rcParamsat the time of their creation, if there were no other settings used. If thercParamsare set in a context, then the lazily-generated ticks may start fetching the wrong values. This is fixed viaAxis._copy_tick_propsby copying the properties from theTick's childArtist's to the new ones. However, internal attributes fromTickare not copied, which is generally fine for drawing because nothing is every re-synced from there.However, in the case of
Spine's window extent, it is generated from the tick direction and size attributes on theTick, so being out of sync may cause an incorrect bounding box if the tick direction changes. SinceSpinechooses a randomTick, this will cause tight/constrained layout to be nondeterministic.Since this is nondeterministic, I'm debating how best to write a test.
Fixes #28574.
PR checklist