Update ruff to 0.2.0 #28593
Merged
Update ruff to 0.2.0 #28593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release deprecated some locations for settings, and moved them into different TOML tables.
And also fix a whitespace linting error (E221) in it.
These are the ones we were using with flake8, but were not available before ruff 0.2.0 (or at least whatever the last tested version was). Also, clean up a bit of the code so that we only use one type of whitespace exception.
oscargus
approved these changes
Jul 19, 2024
tacaswell
reviewed
Jul 24, 2024
| 'spy': 'if isinstance(__ret, cm.ScalarMappable): sci(__ret) # noqa', | ||
| 'spy': ( | ||
| 'if isinstance(__ret, cm.ScalarMappable):\n' | ||
| ' sci(__ret)' |
There was a problem hiding this comment.
just confirming that this looks over indented because the parent has a layer of indentation applied to it?
There was a problem hiding this comment.
Yes, the if gets inserted at a 1-indent level already. The real change here is removing the noqa; since we run black on these auto-generated lines, the result in pyplot.py is no longer an if+code on a single line regardless of how it is written here.
The new line here is just for consistency for readers of this file.
tacaswell
approved these changes
Jul 24, 2024
ksunden
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Note, this release is from Feb 1 of this year, which is only 5.5 months ago, but as we don't document it, nor include it anywhere in requirements, it's only for developers "in the know", so I think using something ~6 months out might be okay? Otherwise, we can wait a little while longer.
This release deprecated some locations for settings, and moved them into different TOML tables.
This release also contains 'preview' linting for the whitespace-related checks that we were waiting on. Enabling these checks required copying some exceptions from
.flake8, and I also tweaked some code so that it only required one exception, instead of some files requiringE201, and someE221. If we want to enable the remaining rules,E302was added in 0.2.2 (Feb 17), butE122is still not supported.I also cleaned up the F401 warnings, as for those ruff requires an actual code on the
noqa.PR checklist