Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC/TST: lock numpy < 2.1 #28779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2024
Merged

DOC/TST: lock numpy < 2.1 #28779

merged 3 commits into from
Sep 3, 2024

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Sep 3, 2024

recent numpy breaks basic_units.py, which breaks the doc build.

Someone should fix basic_units.py, but for now, force version to be smaller than numpy 2.1

@jklymak
Copy link
Member Author

jklymak commented Sep 3, 2024

Anyone should feel free to push changes to this, and/or merge.

@jklymak
Copy link
Member Author

jklymak commented Sep 3, 2024

I'll self merge to unbreak doc builds.

@jklymak jklymak merged commit ef32d22 into matplotlib:main Sep 3, 2024
51 checks passed
@jklymak jklymak deleted the doc-older-numpy branch September 3, 2024 22:00
@QuLogic QuLogic added this to the v3.10.0 milestone Sep 3, 2024
@tacaswell
Copy link
Member

@ksunden is talking with numpy if this is a intended or accidental change to numpy (the source of the problem is related to type coercion with __rmul__ and the change that works with np >=2.1 fails with older versions).

I guess numpy 2.1.1 came out?

@jklymak
Copy link
Member Author

jklymak commented Sep 4, 2024

Yes 2.1.1 is now out

1 similar comment
@Partho-git

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants