Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Break Artist._remove_method reference cycle #28861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tacaswell merged 13 commits into from
Oct 23, 2024
Merged

Break Artist._remove_method reference cycle #28861

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3b42118
Break Artist._remove_method reference cycle
justinjhendrick Sep 21, 2024
867701d
keep old_children swap
justinjhendrick Sep 23, 2024
9d7a505
set _remove_method to None. Add test
justinjhendrick Sep 24, 2024
8a904ab
add scatter to test
justinjhendrick Sep 24, 2024
ff55687
incorporate feedback. disable gc during graph traversal
justinjhendrick Sep 25, 2024
268b330
Merge branch 'main' into axes_clear_children_list
justinjhendrick Sep 25, 2024
ba883a1
try gc disable for whole test
justinjhendrick Sep 25, 2024
2139853
skip test on non-final 3.13.0
justinjhendrick Sep 26, 2024
3f6f591
simplify skip condition
justinjhendrick Sep 26, 2024
74c207d
make all lines in test reachable
justinjhendrick Sep 29, 2024
046b854
Merge branch 'main' into axes_clear_children_list
justinjhendrick Sep 29, 2024
d034312
Merge branch 'main' into axes_clear_children_list
justinjhendrick Oct 14, 2024
5d84a76
Update lib/matplotlib/axes/_base.py
justinjhendrick Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/matplotlib/axes/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1298,9 +1298,11 @@ def __clear(self):
self._get_patches_for_fill = _process_plot_var_args('fill')

self._gridOn = mpl.rcParams['axes.grid']
old_children, self._children = self._children, []
for chld in old_children:
for chld in self._children:
chld.axes = chld._parent_figure = None
# Use list.clear instead of setting _children to empty list to
# break the `artist._remove_method` reference cycle
self._children.clear()
self._mouseover_set = _OrderedSet()
self.child_axes = []
self._current_image = None # strictly for pyplot via _sci, _gci
Expand Down