-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
ci: Bump build image on AppVeyor to MSVC 2019 #28869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3af4f8d
to
a2c9dbc
Compare
Also note that we use Unfortunately, micromamba 2.0.0 seems to have been released in the last day, which broke something. I've opened mamba-org/mamba#3467 with some debug information. |
103be01
to
aeeea07
Compare
I pinned the micromamba version here, so now AppVeyor is running tests, though it looks like there might be some new failures. |
According to the SciPy toolchain roadmap [1], we should be supporting at minimum MSVC 2019. The AppVeyor image has been held back to MSVC 2017 (probably just forgotten since it didn't complain), which is starting to cause issues for more modern code. [1] https://docs.scipy.org/doc/scipy/dev/toolchain.html
Version 2 appears to be broken WRT installing PyPI packages: mamba-org/mamba#3467
I've pinned wxWidgets as well, which broke wxPython: conda-forge/wxpython-feedstock#125 and now we are building. |
Both projects say they have fixed their issues upstream, so I'm going to see if we can revert those. Edit: It looks like micromamba made their release, but haven't updated their "latest" link yet. So I've left the pin for now. |
* ci: Bump build image on AppVeyor to MSVC 2019 According to the SciPy toolchain roadmap [1], we should be supporting at minimum MSVC 2019. The AppVeyor image has been held back to MSVC 2017 (probably just forgotten since it didn't complain), which is starting to cause issues for more modern code. [1] https://docs.scipy.org/doc/scipy/dev/toolchain.html * ci: Pin micromamba on AppVeyor to v1 Version 2 appears to be broken WRT installing PyPI packages: mamba-org/mamba#3467
PR summary
According to the SciPy toolchain roadmap [1], we should be supporting at minimum MSVC 2019. The AppVeyor image has been held back to MSVC 2017 (probably just forgotten since it didn't complain), which is starting to cause issues for more modern code. (Namely #28842 does not work even with the flag for new behaviour.)
There are many other software changes, so I'm opening this separately from #28842 just to confirm it doesn't break anything.
[1] https://docs.scipy.org/doc/scipy/dev/toolchain.html
PR checklist