Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: Bump build image on AppVeyor to MSVC 2019 #28869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Sep 24, 2024

PR summary

According to the SciPy toolchain roadmap [1], we should be supporting at minimum MSVC 2019. The AppVeyor image has been held back to MSVC 2017 (probably just forgotten since it didn't complain), which is starting to cause issues for more modern code. (Namely #28842 does not work even with the flag for new behaviour.)

There are many other software changes, so I'm opening this separately from #28842 just to confirm it doesn't break anything.

[1] https://docs.scipy.org/doc/scipy/dev/toolchain.html

PR checklist

@QuLogic QuLogic added CI: testing CI configuration and testing OS: Microsoft labels Sep 24, 2024
@QuLogic QuLogic mentioned this pull request Sep 24, 2024
3 tasks
@QuLogic QuLogic added this to the v3.10.0 milestone Sep 24, 2024
@QuLogic QuLogic force-pushed the msvc-appveyor branch 2 times, most recently from 3af4f8d to a2c9dbc Compare September 26, 2024 02:59
@QuLogic
Copy link
Member Author

QuLogic commented Sep 26, 2024

Also note that we use windows-latest for the wheels, which is currently Windows Server 2022, and windows-2019 for tests on Azure.

Unfortunately, micromamba 2.0.0 seems to have been released in the last day, which broke something. I've opened mamba-org/mamba#3467 with some debug information.

@QuLogic QuLogic force-pushed the msvc-appveyor branch 5 times, most recently from 103be01 to aeeea07 Compare September 30, 2024 22:36
@QuLogic
Copy link
Member Author

QuLogic commented Sep 30, 2024

I pinned the micromamba version here, so now AppVeyor is running tests, though it looks like there might be some new failures.

According to the SciPy toolchain roadmap [1], we should be supporting at
minimum MSVC 2019. The AppVeyor image has been held back to MSVC 2017
(probably just forgotten since it didn't complain), which is starting to
cause issues for more modern code.

[1] https://docs.scipy.org/doc/scipy/dev/toolchain.html
Version 2 appears to be broken WRT installing PyPI packages:
mamba-org/mamba#3467
@QuLogic
Copy link
Member Author

QuLogic commented Oct 2, 2024

I've pinned wxWidgets as well, which broke wxPython: conda-forge/wxpython-feedstock#125 and now we are building.

@QuLogic
Copy link
Member Author

QuLogic commented Oct 2, 2024

Both projects say they have fixed their issues upstream, so I'm going to see if we can revert those.

Edit: It looks like micromamba made their release, but haven't updated their "latest" link yet. So I've left the pin for now.

@ksunden ksunden merged commit cf84d9a into matplotlib:main Oct 2, 2024
39 of 43 checks passed
@QuLogic QuLogic deleted the msvc-appveyor branch October 2, 2024 20:29
kyracho pushed a commit to kyracho/matplotlib that referenced this pull request Oct 10, 2024
* ci: Bump build image on AppVeyor to MSVC 2019

According to the SciPy toolchain roadmap [1], we should be supporting at
minimum MSVC 2019. The AppVeyor image has been held back to MSVC 2017
(probably just forgotten since it didn't complain), which is starting to
cause issues for more modern code.

[1] https://docs.scipy.org/doc/scipy/dev/toolchain.html

* ci: Pin micromamba on AppVeyor to v1

Version 2 appears to be broken WRT installing PyPI packages:
mamba-org/mamba#3467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: testing CI configuration and testing OS: Microsoft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants