DOC: Better visualization for the default color cycle example #28888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a43f217 to
e4b68de
Compare
story645
reviewed
Sep 25, 2024
We also have "Colormap reference" and "List of named colors" in the gallery. They are likewise a reference. It you want to move them, all three should move together. But that's for another time. I'm only concerned with a better visual representation of the content for now. |
QuLogic
reviewed
Sep 26, 2024
Comment on lines
15
to
17
| def f(x, a): | ||
| return 0.85 * a * (1 / (1 + np.exp(-x)) + 0.2) |
There was a problem hiding this comment.
I don't know what this is from reading it (though I do understand from the final image). Maybe could do with a comment or docstring.
The current visualization is quite messy ( https://matplotlib.org/stable/gallery/color/color_cycle_default.html). Let's focus on: - giving a one clear sequence - giving the color names as 'CN' notation and named colors - showing lines and patches (colors appear substantially different in thin lines and filled areas) And don't bother with: - multiple line widths - they are only a slight visual variation (compared to patches) and multiple widths clutter the example - black background: It's enough to show the default color cycle on the default background.
1b2ec93 to
582459f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current visualization is quite messy (
https://matplotlib.org/stable/gallery/color/color_cycle_default.html).
Let's focus on:
And don't bother with:
New rendered example:
