MNT: Add missing dependency to environment.yml #28890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottshambaugh
approved these changes
Oct 16, 2024
|
Looks like the appveyor build (which uses this file) failed to do the pip install part of it. |
|
Should be fixed by cc8f05f |
|
The bot says "no, this technically does not NEED a rebase" 🤣 |
#28617 introduced parallel gallery builds. This needs joblib as a dependency for sphinx-gallery. `requirements.txt` solves this via `sphinx-gallery[parallel]>=0.12.0`. Unfortunately, conda does not support variants, therefore we have to add the dependency explicitly to `environment.yml`.
7c0ae8b to
d8ccfbc
Compare
QuLogic
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28617 introduced parallel gallery builds. This needs joblib as a dependency for sphinx-gallery.
requirements.txtsolves this viasphinx-gallery[parallel]>=0.12.0. Unfortunately, conda does not support variants, therefore we have to add the dependency explicitly toenvironment.yml.