Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[pre-commit.ci] pre-commit autoupdate #28949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.11.2](pre-commit/mirrors-mypy@v1.10.1...v1.11.2)
- [github.com/pycqa/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1)
- [github.com/rstcheck/rstcheck: v6.2.0 → v6.2.4](rstcheck/rstcheck@v6.2.0...v6.2.4)
- [github.com/python-jsonschema/check-jsonschema: 0.28.6 → 0.29.3](python-jsonschema/check-jsonschema@0.28.6...0.29.3)
@ksunden
Copy link
Member

ksunden commented Oct 8, 2024

Changes appear related to

python-jsonschema/check-jsonschema@64b6ba0#diff-847b5cf820df48bf0feca3b3580c5b827c266cc0923e35c2dd315d9ac1158289R1619

Which disallows extra properties to the workflow_dispatch portion of the on triggers

In both of the indicated files, we have

  workflow_dispatch:
    workflow: "*"

My yaml syntax knowledge is largely based on cargo-culting, so I think it is telling us we should remove the second line, but not sure if the : on the first line also needs to be removed or not... It is a bit odd because the isolated examples just do on: workflow_dispatch, but when there are other triggers it turns into yaml dict, and not sure you can just have the key alone when other fields have sub-entries.

@QuLogic
Copy link
Member

QuLogic commented Oct 8, 2024

The only key under workflow_dispatch is inputs, so I'm not sure what was going on there before, but the workflow key should go away.

@github-actions github-actions bot added the CI: Run cygwin Run cygwin tests on a PR label Oct 8, 2024
@ksunden ksunden added this to the v3.9.3 milestone Oct 9, 2024
@ksunden ksunden merged commit f5e74e1 into main Oct 9, 2024
60 checks passed
@ksunden ksunden deleted the pre-commit-ci-update-config branch October 9, 2024 19:48
Copy link

lumberbot-app bot commented Oct 9, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.9.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 f5e74e1bd48ba8ba9d420acb9f0dfaa52db25e0b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #28949: [pre-commit.ci] pre-commit autoupdate'
  1. Push to a named branch:
git push YOURFORK v3.9.x:auto-backport-of-pr-28949-on-v3.9.x
  1. Create a PR against branch v3.9.x, I would have named this PR:

"Backport PR #28949 on branch v3.9.x ([pre-commit.ci] pre-commit autoupdate)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@QuLogic
Copy link
Member

QuLogic commented Oct 9, 2024

OK, probably not worth backporting.

@QuLogic QuLogic modified the milestones: v3.9.3, v3.10.0 Oct 9, 2024
kyracho pushed a commit to kyracho/matplotlib that referenced this pull request Oct 10, 2024
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.11.2](pre-commit/mirrors-mypy@v1.10.1...v1.11.2)
- [github.com/pycqa/flake8: 7.1.0 → 7.1.1](PyCQA/flake8@7.1.0...7.1.1)
- [github.com/rstcheck/rstcheck: v6.2.0 → v6.2.4](rstcheck/rstcheck@v6.2.0...v6.2.4)
- [github.com/python-jsonschema/check-jsonschema: 0.28.6 → 0.29.3](python-jsonschema/check-jsonschema@0.28.6...0.29.3)

* ci: Remove invalid keys from workflows

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Elliott Sales de Andrade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Run cygwin Run cygwin tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants