Set guiEvent where applicable for gtk4. #28975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Oct 14, 2024
The result of setting or not setting is None here. I'd slightly prefer calling that function nevertheless for enter/leave and let it be an an implementation within gtk4 whether they expose an event or not. |
|
Sure, done. |
QuLogic
approved these changes
Oct 16, 2024
|
AppVeyor failure is Tk, Azure is the usual Homebrew/runner image mismatch, and stubtest is #28978. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, I did not set them for figure_enter_event and figure_leave_event because gtk4 appears leave
controller.get_current_event() as None for them.
Closes #28962.
PR summary
PR checklist