-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
indicate_inset
transform support
#29174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c8e7643
to
ba851c1
Compare
|
||
|
||
@image_comparison(['zoom_inset_transform.png'], remove_text=True, style='mpl20', | ||
tol=0.01) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MacOS tests need the 0.01 tolerance.
470b488
to
0d57221
Compare
0d57221
to
95ed490
Compare
# Set axes on the rectangle (required for some external transforms to work) as | ||
# well as the InsetIndicator artist. | ||
self.rectangle.axes = new_axes | ||
artist.Artist.axes.fset(self, new_axes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the setter logic here from the artist within artist example. I would not have figured it out by myself - thanks @QuLogic for putting it in the example!
PR summary
indicate_inset
docstring, as we are definitely defaulting to transData.main
, my new image test givesaxes
property on the rectangle so that Cartopy transforms will work, and we can do things likePR checklist