ANI: Reduce Pillow frames to RGB when opaque #29236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
In some cases, such as GIF output, Pillow must convert to P (palette) mode. Unfortunately, when done on RGBA images, this can lose some colour information (cf, python-pillow/Pillow#6832) But when the image starts in RGB mode, the conversion to P mode works better, so convert frames to RGB when they don't have any transparent pixels.
Fixes #29190
I'm not sure we have any tests for GIF, etc., other than smoke tests.
PR checklist