Zizmor audit #29251
Merged
Zizmor audit #29251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only have a public repo, and should have locked down permissions on the token, but it's best practice not to leak these out into other steps of the job.
Moved the permissions to the jobs that need them, though this is probably not a big change for the reviewdog workflow. Also drop the `pull-request` permission from the reviewdog workflow, as it's not in the mypy-stubtest one, and still seems to work.
I don't believe `do_no_merge.yml` is unsafe, but there's no need to echo the environment variable (it'll either pass or fail based on the value anyway.) I also don't think the `circleci.yml` context variable is vulnerable, but zizmor warns about it, and it's easy to avoid if turns out to be vulnerable.
|
I pushed a commit to break linting and confirm that reviewdog was still working, and it seems to have posted the failures correctly without the |
tacaswell
approved these changes
Dec 9, 2024
timhoffm
approved these changes
Dec 9, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 9, 2024
greglucas
added a commit
that referenced
this pull request
Dec 9, 2024
…251-on-v3.10.x Backport PR #29251 on branch v3.10.x (Zizmor audit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This applies suggestions from
zizmorto increase the security of the Actions workflows. Currently, we can almost pass the "auditor" persona (the strictest) except for:I do not believe we have any glaring security holes here, but this PR just avoids any cause for concern from auditing.
PR checklist