Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix typo #29257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2024
Merged

fix typo #29257

merged 1 commit into from
Dec 8, 2024

Conversation

musvaage
Copy link
Contributor

@musvaage musvaage commented Dec 8, 2024

solitary fix for a single .rst file

Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@story645 story645 merged commit b358c98 into matplotlib:main Dec 8, 2024
17 of 21 checks passed
@musvaage
Copy link
Contributor Author

musvaage commented Dec 8, 2024

Typos in pull names are of course not slated to be changed.

The following wasn't directly obvious as to what a fix would be; it is quite old anyways.

$ grep -nr compilex matplotlib
matplotlib/doc/users/prev_whats_new/changelog.rst:6117:    are Numeric typecodes and can be used with Numeric compilex extensions.
$

Should be compiled extensions, but maybe such old changelog isn't worth modifying

If I get around to checking the rest of the repo files I'll mention this in another PR.

@WeatherGod
Copy link
Member

WeatherGod commented Dec 9, 2024 via email

@musvaage
Copy link
Contributor Author

musvaage commented Dec 9, 2024

compilex --> compiled

doc/devel/development_setup.rst

that's a logical conclusion as the string compiled extension appears in the above file

@QuLogic QuLogic added this to the v3.11.0 milestone Dec 10, 2024
@musvaage
Copy link
Contributor Author

musvaage commented Dec 10, 2024

Some possible additional fixes.

Homogeneous
compiled
example
functionality
installed
logger
parameters
reset
secondary
tolerance

$ grep -nr Homogenous matplotlib
matplotlib/galleries/users_explain/axes/constrainedlayout_guide.py:535:plt.suptitle('Homogenous nrows, ncols')
$ grep -nr compilex matplotlib
matplotlib/doc/users/prev_whats_new/changelog.rst:6117:    are Numeric typecodes and can be used with Numeric compilex extensions.
$ grep -nr exammple matplotlib
matplotlib/lib/matplotlib/sphinxext/plot_directive.py:35:        plt.title("A plotting exammple")
$ grep -nr functionaliy matplotlib
matplotlib/doc/api/next_api_changes/removals/20866-JKS.rst:5:functionaliy was already replaced by other code, and the only thing left
$ grep -nr instaled matplotlib
matplotlib/pyproject.toml:54:    # Unfortunately, we can't do a sort of minimum-if-instaled dependency, so
$ grep -nr looger matplotlib
matplotlib/doc/api/prev_api_changes/api_changes_3.1.0.rst:536:    # e.g. by configuring a root looger using ``logging.basicConfig()``,
$ grep -n parmeters matplotlib/lib/matplotlib/tests/test_colorbar.py
1211:def test_colorbar_axes_parmeters():
$ grep -nr resete matplotlib
matplotlib/lib/matplotlib/tests/test_widgets.py:1602:    # selector should be automatically resete
$ grep -nr secondart matplotlib
matplotlib/lib/matplotlib/axes/_base.py:1071:            The transform used for drawing secondart y-axis labels, which will
$ grep -nr tolerence matplotlib
matplotlib/doc/api/prev_api_changes/api_changes_3.1.0.rst:798:- The *tolerence* parameter to
$  

Should the blank space be removed?

$ grep -n "pass throughs" matplotlib/lib/matplotlib/category.py
54:        # dtype = object preserves numerical pass throughs
$ 

I presume this is intentional.

$ grep -nr hozirontal matplotlib
matplotlib/lib/matplotlib/tests/test_text.py:412:        Text(rotation='hozirontal')
$

This seems to be bundled customised code.

$ grep -nr intialization matplotlib
matplotlib/subprojects/packagefiles/freetype-2.6.1-meson/include/freetype/config/ftoption.h.in:491:  /*   constants will be moved into a struct and additional intialization  */
$

ci/schemas/conda-environment.json

The above bundled file's typo has been fixed upstream.

microsoft/vscode-python#24574

lib/matplotlib/_color_data.py

The above file contains reproduced xkcd site content which includes typos found in the original.

@musvaage
Copy link
Contributor Author

@story645

I can open a new PR if the matters addressed in my previous comment are of interest.

@QuLogic
Copy link
Member

QuLogic commented Dec 14, 2024

Sure, people probably aren't going to look at a closed PR much.

@story645
Copy link
Member

Sorry for not getting back to it, agree w/ @QuLogic with the caveat that you shouldn't bother w/ anything in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants