Exclude pylab from mypy checks #29267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62cc501 to
181a5ea
Compare
timhoffm
reviewed
Dec 9, 2024
|
pylab is already in the stubtest allowlist I thought this would be simple but apparently I am out of my depth. |
|
The error is 😕 |
|
At least the mypy linting action is happy. That's half way 😄. Not an expert, but I would have tried to mess with this part as well: Lines 224 to 225 in f0ecacc |
|
Success 🎉 |
rcomer
commented
Dec 9, 2024
| @@ -1,7 +1,7 @@ | |||
| # Non-typed (and private) modules/functions | |||
| matplotlib\.backends\..* | |||
| matplotlib\.tests(\..*)? | |||
| matplotlib\.pylab\..* | |||
| matplotlib\.pylab(\..*)? | |||
There was a problem hiding this comment.
Without this change, stubtest both complains that it can't find a stub for pylab and that the allowlist entry is unused. Removing the entry only solved the second complaint. It seemed intuitive to make this line look like the sphinxext line.
timhoffm
approved these changes
Dec 9, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 9, 2024
greglucas
added a commit
that referenced
this pull request
Dec 9, 2024
…267-on-v3.10.x Backport PR #29267 on branch v3.10.x (Exclude pylab from mypy checks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Aiming to close #29263.
PR checklist