-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
BLD: Pin meson-python to <0.17.0 #29295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is currently dropping scalable SVG symlinks, which breaks the toolbar on GTK.
fefcd54
to
a69aa6d
Compare
Do we know what in meson 0.17 broke? Is there an upstream bug report? - I'm asking because thats the prerequisite for getting it fixed / unpinning in the future. |
Yes, it arose from mesonbuild/meson-python#587; I am still investigating if there is a quick way to fix it on our side or whether it will need changes on their side. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…3.9.x Backport PR #29295 on branch v3.9.x (BLD: Pin meson-python to <0.17.0)
…295-on-v3.10.x Backport PR #29295 on branch v3.10.x (BLD: Pin meson-python to <0.17.0)
I've opened mesonbuild/meson-python#713 for meson-python upstream, and we can unpin once that is out in a release. |
PR summary
This is currently dropping scalable SVG symlinks, which breaks the toolbar on GTK.
Fixes #29229
PR checklist