Use _val_or_rc in more places #29354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Dec 20, 2024
| @@ -154,12 +138,12 @@ def __init__( | |||
| self.tick1line = mlines.Line2D( | |||
| [], [], | |||
| color=color, linestyle="none", zorder=zorder, visible=tick1On, | |||
| markeredgecolor=color, markersize=size, markeredgewidth=width, | |||
| markeredgecolor=color, markersize=self._size, markeredgewidth=self._width, | |||
There was a problem hiding this comment.
This may be a behavior change (size might have been None, in which case the default was previously resolved in Line2D, but I believe this here is more correct.
There was a problem hiding this comment.
No, size was replaced in the earlier version, too; I just inlined to the final attribute here instead.
greglucas
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
In some cases where the variable was not used again, I assigned directly to the final variable/attribute. But most of the changes are to the same variables.
PR checklist