Add QtCore.Slot() decorations to FigureCanvasQT #29355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Dec 20, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 20, 2024
timhoffm
added a commit
that referenced
this pull request
Dec 21, 2024
…355-on-v3.10.x Backport PR #29355 on branch v3.10.x (Add QtCore.Slot() decorations to FigureCanvasQT)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This PR adds
QtCore.Slotdecorations to the methods inFigureCanvasQT. (It is similar to #27215)The motivation for this PR was found due to pyqtgraph/pyqtgraph#3205, which can be summarized as: when tests are run with
pytest-qtinstalled, aQtWarningMsgwill be emitted concerning non-decorated methods used as slots.PR checklist
The pyqtgraph tests that were failing prior to this PR have been tested to be passing with this PR with PySide6 6.8.1, PyQt6 6.8.0, PyQt5 5.15, PySide2 5.15