FIX: Add version gate to GTK4 calls when necessary #29363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Dec 20, 2024
| @@ -37,6 +39,7 @@ class FigureCanvasGTK4(_FigureCanvasGTK, Gtk.DrawingArea): | |||
|
|
|||
| def __init__(self, figure=None): | |||
| super().__init__(figure=figure) | |||
| print("GI version", gi.version_info) | |||
There was a problem hiding this comment.
Suggested change
| print("GI version", gi.version_info) |
stray debugging print.
There was a problem hiding this comment.
Thanks! I guess this confirms I was testing it locally with various gi versions ;) and this did work on both lower and upper
get_current_event() calls within pygobject would cause segfaults. This was fixed in 3.47, so gate the guiEvent information to only access that method in versions that don't segfault.
f0f317b to
e18cfda
Compare
tacaswell
approved these changes
Dec 20, 2024
|
"power-cycled" to re-run against current main which should fix the mypy issues. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 6, 2025
rcomer
added a commit
that referenced
this pull request
Jan 6, 2025
…363-on-v3.10.x Backport PR #29363 on branch v3.10.x (FIX: Add version gate to GTK4 calls when necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
get_current_event()calls within pygobject would cause segfaults. This was fixed in 3.47, so gate the guiEvent information to only access that method in versions that don't segfault.closes #29350
PR checklist